Delay loading comment-reply script with async loading strategy#4876
Closed
westonruter wants to merge 2 commits into
Closed
Delay loading comment-reply script with async loading strategy#4876westonruter wants to merge 2 commits into
westonruter wants to merge 2 commits into
Conversation
10 tasks
…into trac-58870 * 'trunk' of https://github.com/WordPress/wordpress-develop: Help/About: Fix the Get Involved tab on Network Admin. Build/Test Tools: Restore automatically retrying failed E2E tests once. Editor: Fix conditionals in Template Editing Mode. Coding Standards: Always declare visibility for class methods. Twenty Twenty-One: Enable Dark Mode in the block editor iframe. HTML API: Change `wp` infix in test classes to `Wp`. Editor: update npm packages with bug fixes for 6.3 RC2. Editor: load title on navigation fallback. Help/About: Updates to About page. Administration: Update dashboard welcome panel for 6.3. Help/About: Add illustrations to the Get Involved tab Editor: Fix abbreviations of "Example" in `block-template-utils.php`. Coding Standards: Remove trailing tabs in `wp-admin/about.php`. Editor: fix popover positioning. Coding Standards: Correct alignment in `wp-includes/media.php`. Media: Fix Image rotation button overflow in translations. Coding Standards: Always use parentheses for class instantiation. General: Commit changes after running `precommit:css`. Media: Fix height max value in image scaling. I18N: Add missing translator comment in `WP_Upgrader::generic_strings()`.
felixarntz
approved these changes
Jul 25, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
LGTM, using async makes sense to me. If there is any plugin that depends on the script, it would still work given that core would then change this script back to blocking.
joemcgill
approved these changes
Jul 27, 2023
Member
Author
|
Committed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58870
Commit message:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.