E2E tests: update cache control headers tests. #4785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the "No private directive present in cache control when user not logged in" test so they won't fail if the headers don't contain a `cache-control` key at all.
johnbillion
approved these changes
Jul 4, 2023
Member
|
The tests are running fine for me locally with this change, but CI still isn't happy. I'll get this in anyway. |
Member
Author
|
Thanks @johnbillion. Agree with you that this doesn't fix the timeouts that we're seeing in CI, but this does make it easier to run these tests locally while debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the "No private directive present in cache control when user not logged in" test so they won't fail if the headers don't contain a
cache-controlkey at all.While trying to debug why E2E tests have been flaky, I noticed that the logged out test for cache control headers was often failing locally because the response headers don't have a
cache-controlkey at all, resulting in aMatcher error: received value must not be null nor undefinedfailure. This adjusts the tests to useexpect.not.objectContaining()instead.Trac ticket: https://core.trac.wordpress.org/ticket/21938
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.