WP Core: Deprecated the wp_queue_comments_for_comment_meta_lazyload() function. (Ticket: 58301)#4489
Closed
SH4LIN wants to merge 7 commits intoWordPress:trunkfrom
Conversation
…e_function() inside the wp_queue_comments_for_comment_meta_lazyload() function. - Updated the DocBlock of WP_Query::lazyload_comment_meta() function.
…mment_meta_lazyload() function
spacedmonkey
requested changes
May 24, 2023
Member
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
One more change and I will commit.
spacedmonkey
approved these changes
May 24, 2023
Member
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Approved. Well done @SH4LIN 🎉
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
I've added a few very minor suggestions inline.
LGTM code wise though.
peterwilsoncc
approved these changes
May 25, 2023
Member
|
Committed 48683a2 |
SH4LIN
deleted the
deprecate-wp-queue-comments-for-comment-meta-lazyload-function/58301
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58301
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.