WP_HTML_Tag_Processor: Support tag closer bookmarks#4115
Closed
adamziel wants to merge 2 commits intoWordPress:trunkfrom
Closed
WP_HTML_Tag_Processor: Support tag closer bookmarks#4115adamziel wants to merge 2 commits intoWordPress:trunkfrom
adamziel wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…king a tag closer This commit marks the start of a bookmark one byte before the tag name start for tag openers, and two bytes before the tag name for tag closers. Setting a bookmark on a tag should set its "start" position before the opening "<", e.g.: ``` <div> Testing a <b>Bookmark</b> ----------------^ ``` The current calculation assumes this is always one byte to the left from $tag_name_starts_at. However, in tag closers that index points to a solidus symbol "/": ``` <div> Testing a <b>Bookmark</b> ----------------------------^ ``` The bookmark should therefore start two bytes before the tag name: ``` <div> Testing a <b>Bookmark</b> ---------------------------^ ```
hellofromtonya
approved these changes
Feb 22, 2023
Contributor
hellofromtonya
left a comment
hellofromtonya
left a comment
There was a problem hiding this comment.
- Before applying
WP_HTML_Tag_Processorchanges, the test fails 🔴 - After applying the
WP_HTML_Tag_Processorchanges, the test passes 🟢
The changes work as described ✅ Ready for commit 👍
Contributor
ockham
added a commit
to WordPress/gutenberg
that referenced
this pull request
Mar 2, 2023
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
ockham
added a commit
to WordPress/gutenberg
that referenced
this pull request
Mar 2, 2023
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR
seek()correctly finds bookmarks set on tag closers. It:array( 'tag_closers' => 'visit' )inseek()About bookmark start indices:
Setting a bookmark on a tag should set its "start" position before the opening "<", e.g.:
The current calculation assumes this is always one byte to the left from $tag_name_starts_at.
However, in tag closers that index points to a solidus symbol "/":
The bookmark should therefore start two bytes before the tag name:
Trac ticket: https://core.trac.wordpress.org/ticket/57787
cc @ockham @dmsnell @gziolo