Switch copy_dir() with move_dir() in WP_Upgrader::install_package() #3911
Conversation
afragen
force-pushed
the
move-dir-switch
branch
from
d985ff9 to
bce22eb
Compare
|
This PR will fail until PR3903 has been committed. |
|
Tests are failing and will fail as |
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Added a note to account for whether the working directory ought to be cleared.
During manual testing this is what happens on trunk, ie not this PR:
- at the start of an update, the
upgradefolder is emptied - currently updated item is extracted to that folder
- with
clear_working => falsethe theme/plugin is not deleted from theupgradefolder - with
clear_working => truethe theme/plugin is deleted from theupgradefolder
So when bulk updating a bunch of themes/plugins, after the upgrade process is complete only one folder is retained (per screen shot). I think the purpose of retaining the folder is to allow plugin authors to do something (I don't know what) with the working copy after the end of the update.
The inline change will have little affect as core always clears the working folder but it's best to account for it.
|
Merged. |
6 participants
While working extensively on #57375 in various discussions on that ticket and on Slack it was decided to move forward with PR3909.
PR3909 does not include the needed change to WP_Upgrader::install_package() to take advantage of its new code. This ticket and PR will accomplish that. The plan is to replace copy_dir() in WP_Upgrader::install_package() with move_dir().
This change was tested extensively during the development of #57375
Related: #57375, #57386
Trac ticket: https://core.trac.wordpress.org/ticket/57557