Safe style css: Add position CSS properties to support position controls in blocks #3865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 tasks
Member
|
@andrewserong Left one feedback |
13 tasks
hellofromtonya
approved these changes
Feb 1, 2023
Contributor
hellofromtonya
left a comment
hellofromtonya
left a comment
There was a problem hiding this comment.
- Confirmed this PR does cover the needed changes from the GB PR ✅
Changes LGTM 👍 Marking for commit.
Contributor
|
Sorry the delay in reviewing this. It didn't have the things I'm tracking in Trac query for finding backports. Added the |
Contributor
Contributor
Author
|
Wonderful, thank you! Now that this has landed, I'll put together the follow up changes for the rest of the position block support 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following CSS properties to
safe_style_cssto support positioning:positiontoprightbottomleftz-indexThis is a prerequisite for rolling out a feature from Gutenberg that allows container blocks (e.g. Group) to be set to a particular position (e.g. sticky or fixed). For more context, see the Gutenberg PR: WordPress/gutenberg#46142
The goal with adding these CSS properties is to be able to support (especially in the longer term) sticky/fixed/relative/absolute positioning of blocks, a position offset (top/right/bottom/left) and which block sits ontop of another block (so that sticky/fixed blocks can sit above site or post content).
To test, ensure the tests pass, or if you're using the Docker environment for
wordpress-develop, run the following locally:npm run test:php /var/www/tests/phpunit/tests/kses.phpTrac ticket: https://core.trac.wordpress.org/ticket/57504
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.