Added check to see if username supplied already exists.#3809
Added check to see if username supplied already exists.#3809JosephGabito wants to merge 10 commits intoWordPress:trunkfrom
Conversation
|
Hi @JosephGabito! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @JosephGabito, Left comment that fixed the PHPCS error.
Co-authored-by: Mukesh Panchal <[email protected]>
|
@mukeshpanchal27 Thanks. I've applied your suggestions as commit. Cheers |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @JosephGabito for the update. Left one feedback for the translation.
Co-authored-by: Mukesh Panchal <[email protected]>
Update user.php
|
Hi @adamsilverstein, @JosephGabito I added a unit test for this fix. |
Update user.php
Update user.php
|
Fixed the failing code standards issue. |
Trac ticket: https://core.trac.wordpress.org/ticket/57394