Skip to content

Added check to see if username supplied already exists.#3809

Open
JosephGabito wants to merge 10 commits intoWordPress:trunkfrom
JosephGabito:trac-57394
Open

Added check to see if username supplied already exists.#3809
JosephGabito wants to merge 10 commits intoWordPress:trunkfrom
JosephGabito:trac-57394

Conversation

@JosephGabito
Copy link

@github-actions
Copy link

Hi @JosephGabito! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JosephGabito, Left comment that fixed the PHPCS error.

Co-authored-by: Mukesh Panchal <[email protected]>
@JosephGabito
Copy link
Author

@mukeshpanchal27 Thanks. I've applied your suggestions as commit. Cheers

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JosephGabito for the update. Left one feedback for the translation.

@ajayver
Copy link

ajayver commented Feb 17, 2023

Hi @adamsilverstein, @JosephGabito I added a unit test for this fix.

@ajayver
Copy link

ajayver commented Feb 17, 2023

Fixed the failing code standards issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants