Upgrader copy directory filter #3805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
requested changes
Jan 4, 2023
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
As discussed in Slack and posted on trac a couple of weeks ago, I don't think this is a suitable filter for Core.
It provides no general purpose benefit to theme and plugin developers.
Please use the custom actions hooks for testing the rollback plugin.
afragen
force-pushed
the
upgrader-copy-directory-filter
branch
from
b4ce18e to
344c4dc
Compare
… into upgrader-copy-directory-filter
Member
Author
|
PR now using switch filter. if ( ! apply_filters( 'upgrader_use_move_dir', false, ... ) {
copy_dir();
} else {
move_dir();
} |
Member
Author
|
Closing in favor of PR3911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_dir()is a recursive file copy for directories and is used when updating plugins, themes, and core.There are several tickets related to timeouts and optimization of the update process. As part of Rollback #51857, a new function
move_dir()and a new filter #56057 were introduced. This ticket is an improvement upon #56057.Optimizing the plugin/theme update process can be solved using the
move_dir()function and a filter similar to #56057.#57357 was opened to add
move_dir()to core. This ticket is to add the new filter.The new filter would easily allow the substitution of
move_dirforcopy_diradding more efficiency to the plugin/theme update process by having the user add a simple filter. This could improve the efficiency and performance for 99+% of users who opt-in and will likely fix #53832, #54166, and #34676.I believe the use cases are sufficient to merit inclusion to core, additionally both of these have been tested rigorously in the Rollback PR/feature plugin.
Trac ticket: https://core.trac.wordpress.org/ticket/57386
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.