Pass $locale to override_load_textdomain filter#3600
Closed
cadic wants to merge 3 commits intoWordPress:trunkfrom
Closed
Pass $locale to override_load_textdomain filter#3600cadic wants to merge 3 commits intoWordPress:trunkfrom
cadic wants to merge 3 commits intoWordPress:trunkfrom
Conversation
ocean90
requested changes
Nov 10, 2022
ocean90
changed the title
Co-authored-by: Dominik Schilling <[email protected]>
costdev
reviewed
Dec 5, 2022
Co-authored-by: Colin Stewart <[email protected]>
Member
|
Would it make sense to move the locale detection earlier in the function, so that it's always passed as a string to the filter, instead of |
Member
|
IIRC that get_locale() call is deliberately as late as possible to avoid too many calls for performance reasons. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In [53874] the
$localeparameter was added toload_textdomain()so it can be used to properly fillWP_Textdomain_Registry.Since the
$localemay not be the same value asdetermine_locale()returns (e.g. when filtered byplugin_localeinload_plugin_textdomain()) we should also pass the new parameter to the filter so custom file loading implementations are using the same locale asload_textdomain()got.Trac ticket: https://core.trac.wordpress.org/ticket/57056
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.