Prime network options in a single cache call using wp_cache_get_multiple#3528
Prime network options in a single cache call using wp_cache_get_multiple#3528spacedmonkey wants to merge 13 commits intoWordPress:trunkfrom
Conversation
spacedmonkey
requested review from
JJJ,
desrosj,
felixarntz and
peterwilsoncc
|
Desperately want to pre-register these keys using |
Where I personally agree, I feel like that is a larger discussion. This ticket is simple and easier to commit. If this get "fixed" by using the meta api down the line then so be it. |
|
@JJJ Question, how around using a autoload attribute work for multisite. This function is called early in the bootstrap. So would likely require register settings in a sunrise or advanced cache file. This feels weird and unlikely to happen. |
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @spacedmonkey for the changes. Look good to me.
Do we need to update description for the function as now we use cache?
Loads and caches certain often requested site options if is_multisite() and a persistent cache is not being used.
Co-authored-by: Peter Wilson <[email protected]>
spacedmonkey
changed the title
spacedmonkey
changed the title
spacedmonkey
requested review from
johnbillion and
oglekler
and removed request for
oglekler
Co-authored-by: Jeremy Felt <[email protected]>
|
Committed efc70be |
7 participants
Trac ticket: https://core.trac.wordpress.org/ticket/56913
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.