Skip to content

Conversation

@kebbet
Copy link

@kebbet kebbet commented Oct 25, 2022

@kebbet kebbet marked this pull request as ready for review October 25, 2022 13:26
Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated SVGs look good — no visual changes and it cuts down on file size 👍🏻

The freedoms & privacy SVGs technically don't need the a11y attributes, since they're used as imgs, but it doesn't hurt to have them.

@ryelle
Copy link
Contributor

ryelle commented Oct 25, 2022

Committed in r54690

@ryelle ryelle closed this Oct 25, 2022
@sabernhardt
Copy link

@ryelle basically said what I was writing :)

The dashboard image needed the extra attributes because it is an inline SVG there. In the About pages, the graphics are added in img tags with empty alt attributes. The aria-hidden="true" and focusable="false" might be worth adding to the other images for consistency, though, or to support the possibility of including them inline somewhere.

@kebbet kebbet deleted the 6.1-about-graphics branch October 25, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants