Help/About: Update links on About page #3459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
commented
Oct 13, 2022
| /* translators: %s: WordPress Field Guide link. */ | ||
| __( 'Check out the latest version of the <a href="%s">WordPress Field Guide</a>. It is overflowing with detailed developer notes to help you build with WordPress.' ), | ||
| __( '#' ) | ||
| __( 'https://make.wordpress.org/core/2022/10/12/wordpress-6-1-field-guide/' ) |
Contributor
Author
There was a problem hiding this comment.
This was translated in the 6.0 page, but should it be? Do translators fork this page?
There was a problem hiding this comment.
No locale has translated it, see ”Other languages”-tab here https://translate.wordpress.org/projects/wp/6.0.x/admin/sv/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=14634812&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc&historypage
There was a problem hiding this comment.
Sorry, I was wrong! It has been translated to French by @audrasjb
Contributor
Author
There was a problem hiding this comment.
Thanks for looking it up! I'll leave this as a translatable string then 👍🏻
ryelle
force-pushed
the
update/61-about-links
branch
from
643afae to
8b5f484
Compare
Contributor
Author
|
Committed as part of r54635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've updated the learn copy (comment 37) & added the links mentioned in comments 38, 40, 41, and added a translation wrapper around the performance plugin link (comment 44). Also updated the field guide link.
The "header & footer" section has been removed in and replaced with the "fluid typography" section from the icon grid.
The intro sentence with "2,000" in it has been removed.
View page screenshot
Trac ticket: https://core.trac.wordpress.org/ticket/56357
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.