Fixed PHP 8.1.10 bug Core WP Deprecated errors#3301
Open
thejaydip wants to merge 1 commit intoWordPress:trunkfrom
Open
Fixed PHP 8.1.10 bug Core WP Deprecated errors#3301thejaydip wants to merge 1 commit intoWordPress:trunkfrom
thejaydip wants to merge 1 commit intoWordPress:trunkfrom
Conversation
jrfnl
requested changes
Sep 21, 2022
Member
There was a problem hiding this comment.
@thejaydip This is not the right fix. A backtrace is needed to find the source of the problem and it should be fixed at the source, not where the deprecation is being thrown.
Note: the Trac ticket you've associated with this PR is also unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check non-empty variable before return may be it will work.
Trac ticket: https://core.trac.wordpress.org/ticket/56612