Skip to content

Meta query add faster compare modes#3293

Open
mehulkaklotar wants to merge 29 commits intoWordPress:trunkfrom
mehulkaklotar:meta_query_add_faster_compare_modes
Open

Meta query add faster compare modes#3293
mehulkaklotar wants to merge 29 commits intoWordPress:trunkfrom
mehulkaklotar:meta_query_add_faster_compare_modes

Conversation

@mehulkaklotar
Copy link
Member

@mehulkaklotar mehulkaklotar commented Sep 20, 2022 •
edited
Loading

Adds the new LIKE based compare operators STARTSWITH, ENDSWITH, NOT STARTSWITH, NOT ENDSWITH to the meta query value compares.
They allow more performant and easier regular query cases than REGEXP which would be the alternative.

This PR is a fork from existing PR as contributor is temporarily unavailable to work on the changes.

Trac ticket: https://core.trac.wordpress.org/ticket/53450

Testing Instructions

  1. Create posts with meta listed below
  2. Create WP Meta Queries to get results
  3. Results should be according to meta query

Post 1 - Meta Key xyz - Meta Value abc

Meta Query:

new WP_Query(
	array(
		'update_post_meta_cache' => false,
		'update_post_term_cache' => false,
		'fields'                 => 'ids',
		'meta_query'             => array(
			array(
				'key'               => 'xyz',
				'value'             => 'abc',
				'compare'           => 'LIKE',
			),
		),
	)
);

Post 1 - Meta Key -> xyz - Meta Value abcstartswith
Post 2 - Meta Key -> xyz - Meta Value endswithabc
Post 3 - Meta Key -> xyz - Meta Value containsabccontains
Post 4 - Meta Key -> xyz - Meta Value pqr
Post 5 - Meta Key -> xyz - Meta Value abcabcabc

Meta Query:

new WP_Query(
	array(
		'update_post_meta_cache' => false,
		'update_post_term_cache' => false,
		'fields'                 => 'ids',
		'meta_query'             => array(
			array(
				'key'               => 'xyz',
				'value'             => 'abc',
				'compare'           => 'LIKE',
				'compare_like_mode' => 'startswith',
			),
		),
	)
);

Meta Query:

new WP_Query(
	array(
		'update_post_meta_cache' => false,
		'update_post_term_cache' => false,
		'fields'                 => 'ids',
		'meta_query'             => array(
			array(
				'key'               => 'xyz',
				'value'             => 'abc',
				'compare'           => 'LIKE',
				'compare_like_mode' => 'endswith',
			),
		),
	)
);

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

JanThiel and others added 29 commits June 18, 2021 17:48
@JanThiel
Adds the new LIKE based compare operators STARTSWITH, ENDSWITH, NOT S…
4d5175f 
…TARTSWITH, NOT ENDSWITH to the meta query value compares. They allow more performant regular query cases than REGEXP which would be the alternative.
@JanThiel
CodeStyle fixes
6676114
@JanThiel
Fixes typo in ENDSWITH compare operator
735a5a8
@JanThiel
Fix another Typo in condition string
b63b98c
@JanThiel
Adds more complex testcases to the new compare Operators
c2633ae
@JanThiel
Adds meta query properties to configure the search mode when using LI…
ee2fe11 
…KE. Also extends this to key searches and adds testcases.
@JanThiel
Code Format fixes
0b844e5
@JanThiel
Adds test and ability to use LIKE compare mode selectors as meta_... …
e057ca8 
…keys in WP_Query directly
@JanThiel
Merge remote-tracking branch 'origin/master' into 53450_meta_query_ad…
693f5d6 
…d_faster_compare_modes
@JanThiel
Removes previous ENDSWITH and STARTSWITH cases
8d618b1
@JanThiel
Fixes codestyle issue
dd04e28
@JanThiel
Fixes codestyle issue
27d2bf3
@JanThiel
Fixes codestyle issue
7e37fc8
@JanThiel
Merge branch 'WordPress:master' into 53450_meta_query_add_faster_comp…
61f582c 
…are_modes
@JanThiel
Change parameter order in comment
67852b3 
Implements DEV feedback
@JanThiel
Merge branch 'master' into 53450_meta_query_add_faster_compare_modes
652248f
@JanThiel
Merged trunk and bumped @SInCE to 6.0.0
04d998d
@JanThiel
Streamlined tests after code review
18ccf51
@JanThiel
Code Formatting fix
8c72195
@JanThiel
Adds missing $expected
0369108
@JanThiel
Merge with trunk
31496b0
@JanThiel
Adds missing trailing dot
6da30a8
@JanThiel
Merge branch 'trunk' into 53450_meta_query_add_faster_compare_modes
32f8c97
@JanThiel
Update @SInCE comment for like mode
b186936
@JanThiel
Merge branch 'WordPress:trunk' into 53450_meta_query_add_faster_compa…
859cdae 
…re_modes
@JanThiel
Merge remote-tracking branch 'wp/trunk' into 53450_meta_query_add_fas…
dbc9c68 
…ter_compare_modes
@JanThiel
Merge branch '53450_meta_query_add_faster_compare_modes' of github.co…
c704641 
…m:JanThiel/wordpress-develop into 53450_meta_query_add_faster_compare_modes
@mehulkaklotar
meta query fixes for the default like query
16b50a8
@mehulkaklotar
tests meta query fixes for the default like query ticket info added
802c298
@SainathPoojary SainathPoojary mentioned this pull request Mar 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mehulkaklotar @JanThiel