Block Template : Ensure only the main query is modified when resolving template for new posts. #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
approved these changes
Jun 28, 2022
Contributor
There was a problem hiding this comment.
This looks good to me. I know @petitphp mentioned the issue is also present in WordPress 5.9 – @SergeyBiryukov, what does the process for that look like? Should it be a separate PR, or would you be able to reuse this one when committing?
Member
I think we generally only backport bug fixes to the latest stable branch, which is 6.0.x at the moment. The 5.9.x branch would only be open for security fixes at this point. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add check for the main query before modying it when resolving the template for new posts.
Why?
Fix 404 response when resolving template for new posts/pages resulting of the wrong query being modified.
Testing Instructions
Trac ticket: https://core.trac.wordpress.org/ticket/56058