Normalize to Unicode NFC encoding before converting accent characters #2820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Position of added snippet moved.
Note: these are NOT the same encodings used for the original `test_remove_accents_latin1_supplement()` function, though they are visually identical.
azaozz
reviewed
Jun 17, 2022
Test is skipped if required extension isn't present. Only impacts non-NFC encoded tests, like this one.
azaozz
reviewed
Jun 28, 2022
Contributor
|
Closed in favor of #3000 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh of previous patch for #24661, with addition of unit test to convert NFD-encoded strings.
Trac ticket: https://core.trac.wordpress.org/ticket/24661
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.