#43886 - Prevent new-password auto-fill in Chrome. #2273
Conversation
| <th scope="row"><label for="pwd"><?php _e( 'Password' ); ?></label></th> | ||
| <td><input name="pwd" id="pwd" type="text" aria-describedby="pwd-desc" size="25" value="<?php echo htmlspecialchars( _x( 'password', 'example password' ), ENT_QUOTES ); ?>" autocomplete="off" /></td> | ||
| <td><input name="pwd" id="pwd" type="text" aria-describedby="pwd-desc" size="25" value="<?php echo htmlspecialchars( _x( 'password', 'example password' ), ENT_QUOTES ); ?>" autocomplete="new-password" /></td> | ||
| <td id="pwd-desc"><?php _e( 'Your database password.' ); ?></td> |
There was a problem hiding this comment.
I'm not sure about this change. The database password is a current password, but not one that belongs to the individual filling out the form.
It would be good to test this with some browsers and browser extensions such as LastPass and 1Password.
There was a problem hiding this comment.
It's also not a new password in any meaningful sense; it's an existing password. If any browser or extension acknowledged this and offered a new password, I don't see any case where they would be offering a useful piece of information.
There was a problem hiding this comment.
I asked for some advice from a contact I have at 1Password to see if there's a practical way around this. I know you can have autocomplete="section-some-section shipping|billing address" so I am hoping something similar is available that may help here.
I'll let you know if I hear back anything of use.
|
changes committed in revision 53111 |
4 participants
Trac ticket: https://core.trac.wordpress.org/ticket/43886
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.