-
Notifications
You must be signed in to change notification settings - Fork 3.2k
#53299 - Add support for ENUM in is_serialized() detection. #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @konradyoast! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
I've added several tests to confirm existing behaviour of the To test the Enum serialization, I've created and serialized an Enum on 3v4l.org ((link)[https://3v4l.org/J6h8o]). The given input and result there are shown below for PHP 8.1, which confirms the case for the <?php
enum Foo
{
case bar;
}
echo serialize( Foo::bar );
// E:7:"Foo:bar"; |
costdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests @konradyoast! This review makes suggestions for consistency in the test suite and some additional datasets.
To committers:
This commit is a docs change which should be committed separately from the unit tests included in this PR.
costdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @konradyoast! LGTM 👍
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trac ticket: https://core.trac.wordpress.org/ticket/53299