Skip to content

Conversation

@konradyoast
Copy link

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Hi @konradyoast! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@d-claassen
Copy link

I've added several tests to confirm existing behaviour of the is_serialize() function. I've based the input for these tests on the existing tests for is_serialized_string.

To test the Enum serialization, I've created and serialized an Enum on 3v4l.org ((link)[https://3v4l.org/J6h8o]). The given input and result there are shown below for PHP 8.1, which confirms the case for the E character that's added in the is_serialize() function.

<?php

enum Foo
{
    case bar;
}

echo serialize( Foo::bar );
// E:7:"Foo:bar";

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests @konradyoast! This review makes suggestions for consistency in the test suite and some additional datasets.

To committers:
This commit is a docs change which should be committed separately from the unit tests included in this PR.

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @konradyoast! LGTM 👍

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audrasjb
Copy link
Contributor

committed in https://core.trac.wordpress.org/changeset/53886

@audrasjb audrasjb closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants