Fixes #54106 and adds tests by pbearne · Pull Request #2242 · WordPress/wordpress-develop

pbearne · 2022-01-29T00:00:04Z

now removes _wp_http_referer from the url when creating a hidden input for _wp_http_referer

Trac ticket: https://core.trac.wordpress.org/ticket/54106

dream-encode

Just some small changes and a suggestion. Also, should resync upstream as patching current fails for tests/phpunit/tests/term/getTermBy.php.

src/wp-includes/functions.php

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

tests/phpunit/tests/term/getTermBy.php

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

mukeshpanchal27

Left some feedback and improvement changes in tests.

src/wp-includes/functions.php

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

tests/phpunit/tests/functions/wpRefererFeld.php

mukeshpanchal27

A couple of formatting/standards comments

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

tests/phpunit/tests/functions/wpRefererFeld.php

Co-authored-by: David B <[email protected]>

Co-authored-by: Mukesh Panchal <[email protected]>

reordered comments block

Co-authored-by: Mukesh Panchal <[email protected]>

mukeshpanchal27

@pbearne PR look solid now. Left one review that fix the unit tests.

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

Co-authored-by: Mukesh Panchal <[email protected]>

costdev

Thanks for the PR @pbearne! I've left some thoughts and suggestions below.

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

tests/phpunit/tests/functions/wpRefererFeld.php

src/wp-includes/functions.php

Co-authored-by: Colin Stewart <[email protected]>

…ip_referer

mukeshpanchal27 · 2022-09-01T09:55:04Z

@dream-encode @costdev Can you please re-review?

costdev

LGTM 👍 Could do with a re-run of CI to get that failing test passing.

mukeshpanchal27 · 2022-09-01T12:05:23Z

It's a core issue https://wordpress.slack.com/archives/C02RQBWTW/p1662025984130089?thread_ts=1661992665.658499&cid=C02RQBWTW That will be fixed soon, and then all tests will pass.

robinwpdeveloper · 2022-09-17T08:25:07Z

LGTM as well.
Thanks @pbearne

src/wp-includes/functions.php

Co-authored-by: David B <[email protected]>

src/wp-includes/functions.php

hz-tyfoon

need to remove extra closing bracket.

tests/phpunit/tests/functions/wpRefererFeld.php

Co-authored-by: David B <[email protected]>

Co-authored-by: Mukesh Panchal <[email protected]>

…ip_referer

src/wp-includes/functions.php

audrasjb

LGTM

audrasjb · 2022-10-09T22:39:15Z

Ah well… now it doesn't look good to me: this PR adds a new wpRefererFeld.php file in tests, but there's already a wpRefererField.php file :)

Ping @pbearne

See #2242 (comment)

tests/phpunit/tests/functions/wpRefererFeld.php

mukeshpanchal27 · 2022-10-10T15:37:52Z

@audrasjb Can you please review it. It's ready for final review and merge.

audrasjb

Thanks Mukesh 👍

audrasjb · 2022-10-10T18:59:33Z

Committed in https://core.trac.wordpress.org/changeset/54449

pbearne added 4 commits January 28, 2022 18:58

Fixes #54106 and adds tests

de8db74

whitespace

2e46d53

whitespace

59d1291

test for _wp_check_existing_file_names

5ea0a83

dream-encode requested changes Mar 18, 2022

View reviewed changes

mukeshpanchal27 reviewed Aug 23, 2022

View reviewed changes

pbearne and others added 13 commits August 23, 2022 10:56

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

dd5c78d

Co-authored-by: David B <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

fe99f16

Co-authored-by: David B <[email protected]>

Update tests/phpunit/tests/term/getTermBy.php

8c1b888

Co-authored-by: David B <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

1426767

Co-authored-by: David B <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

fa652ea

Co-authored-by: David B <[email protected]>

Update src/wp-includes/functions.php

ad7720b

Co-authored-by: Mukesh Panchal <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

648032a

Co-authored-by: Mukesh Panchal <[email protected]>

Update tests/phpunit/tests/functions/wpRefererFeld.php

db3ef6b

Co-authored-by: Mukesh Panchal <[email protected]>

Update tests/phpunit/tests/functions/wpRefererFeld.php

2ca133f

Co-authored-by: Mukesh Panchal <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

4fdc008

Co-authored-by: Mukesh Panchal <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

6871c90

Co-authored-by: Mukesh Panchal <[email protected]>

Update _wpCheckExistingFileNames.php

2c14c89

reordered comments block

Update tests/phpunit/tests/functions/wpRefererFeld.php

3811a1f

Co-authored-by: Mukesh Panchal <[email protected]>

mukeshpanchal27 reviewed Aug 30, 2022

View reviewed changes

tests/phpunit/tests/functions/_wpCheckExistingFileNames.php Outdated Show resolved Hide resolved

pbearne and others added 2 commits August 30, 2022 07:55

Update tests/phpunit/tests/functions/wpRefererFeld.php

43777d5

Co-authored-by: Mukesh Panchal <[email protected]>

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

ba178fd

Co-authored-by: Mukesh Panchal <[email protected]>

costdev requested changes Aug 30, 2022

View reviewed changes

pbearne and others added 5 commits August 31, 2022 08:10

Update tests/phpunit/tests/functions/_wpCheckExistingFileNames.php

6c4f143

Co-authored-by: Colin Stewart <[email protected]>

Update tests/phpunit/tests/functions/wpRefererFeld.php

d502d8c

Co-authored-by: Colin Stewart <[email protected]>

Merge branch 'WordPress:trunk' into #54106_wp_nonce_field_doesn't_str…

a9bb1e2

…ip_referer

swapped esc_att to esc_url

4ff6c06

removed not needed file

d30b71f

costdev approved these changes Sep 1, 2022

View reviewed changes

mukeshpanchal27 approved these changes Sep 1, 2022

View reviewed changes

remove empty line

efb272b

dream-encode reviewed Sep 27, 2022

View reviewed changes

src/wp-includes/functions.php Outdated Show resolved Hide resolved

Update src/wp-includes/functions.php

9868f1e

Co-authored-by: David B <[email protected]>

mukeshpanchal27 reviewed Sep 28, 2022

View reviewed changes

src/wp-includes/functions.php Outdated Show resolved Hide resolved

hz-tyfoon approved these changes Sep 28, 2022

View reviewed changes

dream-encode reviewed Sep 28, 2022

View reviewed changes

tests/phpunit/tests/functions/wpRefererFeld.php Outdated Show resolved Hide resolved

pbearne and others added 5 commits September 28, 2022 19:36

Update tests/phpunit/tests/functions/wpRefererFeld.php

5bd2936

Co-authored-by: David B <[email protected]>

Update src/wp-includes/functions.php

dcc86b6

Co-authored-by: Mukesh Panchal <[email protected]>

Merge branch 'WordPress:trunk' into #54106_wp_nonce_field_doesn't_str…

a73480a

…ip_referer

whitespace

06db015

fixed test

47e9557

adamsilverstein reviewed Oct 5, 2022

View reviewed changes

src/wp-includes/functions.php Show resolved Hide resolved

audrasjb previously approved these changes Oct 9, 2022

View reviewed changes

audrasjb requested changes Oct 9, 2022

View reviewed changes

tests/phpunit/tests/functions/wpRefererFeld.php Show resolved Hide resolved

pbearne added 2 commits October 10, 2022 11:20

Merge branch 'trunk' into #54106_wp_nonce_field_doesn't_strip_referer

6e51a2a

Merged tests into existing test file

5ee4e84

mukeshpanchal27 approved these changes Oct 10, 2022

View reviewed changes

audrasjb approved these changes Oct 10, 2022

View reviewed changes

audrasjb closed this Oct 10, 2022

Comments

Conversation

pbearne commented Jan 29, 2022

Uh oh!

dream-encode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

costdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 commented Sep 1, 2022

Uh oh!

costdev left a comment

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 commented Sep 1, 2022

Uh oh!

robinwpdeveloper commented Sep 17, 2022

Uh oh!

Uh oh!

Uh oh!

hz-tyfoon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

audrasjb left a comment

Choose a reason for hiding this comment

Uh oh!

audrasjb commented Oct 9, 2022

Uh oh!

Uh oh!

mukeshpanchal27 commented Oct 10, 2022

Uh oh!

audrasjb left a comment

Choose a reason for hiding this comment

Uh oh!

audrasjb commented Oct 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hz-tyfoon left a comment •

edited

Loading