Add/upload plugin e2e tests #1931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @kevin940726, when you have some time, this PR might need some review. |
kevin940726
reviewed
Jan 13, 2022
Comment on lines
+36
to
+45
| if (pluginStatus === 'active') { | ||
| await deactivatePlugin(pluginSlug); | ||
| await uninstallPlugin(pluginSlug); | ||
| await installPlugin(pluginSlug, pluginName); | ||
| } else if (pluginStatus === 'inactive') { | ||
| await uninstallPlugin(pluginSlug); | ||
| await installPlugin(pluginSlug, pluginName); | ||
| } else { | ||
| await installPlugin(pluginSlug, pluginName); | ||
| } |
There was a problem hiding this comment.
We could just do this, might be simpler:
Suggested change
| if (pluginStatus === 'active') { | |
| await deactivatePlugin(pluginSlug); | |
| await uninstallPlugin(pluginSlug); | |
| await installPlugin(pluginSlug, pluginName); | |
| } else if (pluginStatus === 'inactive') { | |
| await uninstallPlugin(pluginSlug); | |
| await installPlugin(pluginSlug, pluginName); | |
| } else { | |
| await installPlugin(pluginSlug, pluginName); | |
| } | |
| if (pluginStatus === 'active') { | |
| await deactivatePlugin(pluginSlug); | |
| } | |
| if (pluginStatus === 'inactive') { | |
| await uninstallPlugin(pluginSlug); | |
| } | |
| await installPlugin(pluginSlug, pluginName); |
|
|
||
| describe('Manage uploading new plugin/theme version', () => { | ||
| const pluginSlug = 'classic-editor'; | ||
| const pluginName = 'Classic Editor'; |
There was a problem hiding this comment.
Could we use a smaller and test-purposed plugin instead? It will have some benefits:
- We'll be able to manage the zip source and check it into the source control as well.
- The plugin name can be explicitly named for testing purposes.
- We won't mess with the download count in wp.org.
- It will be clear in the test whether the installation is an upgrade or a downgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Trac Ticket: https://core.trac.wordpress.org/ticket/54334
Test Scenario