Update copy_dir() to initially try rename() instead of file copy
#1725
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afragen
changed the title
copy_dir() to initially try rename() instead of file copy
aristath
reviewed
Oct 1, 2021
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
Brillian debugging, thank you!
Wouldn't this change the behaviour of the copy_dir() function completely, making it a move function?
Perhaps we should change
rename() or $wp_filesystem->move() instead of copy_dir()?
Member
Author
|
After some discussion with @aristath I think a new PR with a move_dir function and leave copy_dir intact. Will close this PR once that one up. |
Member
Author
|
New PR is at #1727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
copy_dir()to try arename()before attempting to copy file by file. On large plugins with many files a file copy will result in a timeout on a slow system. The patch should revert to a file copy if therename()fails.I was able to timeout the installation of WooCommerce, Yoast SEO, and MailPoet on the Docker WP test env. With this patch each plugin installs fine.
Trac ticket: https://core.trac.wordpress.org/ticket/51857
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.