Skip to content

Conversation

@oandregal
Copy link
Member

@oandregal oandregal commented Jul 8, 2021

Part of https://core.trac.wordpress.org/ticket/53175

This ports this PR WordPress/gutenberg#33280 The JS changes in that PR will be ported in the next package release and both are independent (they fix two related but separate things).

How to test

  • Add these contents to a file named theme.json in the TwentyTwentyOne theme (or add the same contents to any theme with theme.json support):
{
  "version": 1,
  "settings": {
    "color": {
      "duotone": []
    },
    "spacing": {
      "units": []
    }
  }
}
  • Open the post editor.
  • Add a cover block. Go to the inspector and verify that the padding control only show px units. Before this change, it'll show all units.
  • Add an image block. Open the duotone control from the block toolbar. The expected result is that it doesn't show any duotone colors. Before this change, it'll still show all colors.

Captura de ecrã de 2021-07-08 11-38-45

@oandregal
Copy link
Member Author

cc @desrosj @youknowriad @jorgefilipecosta in case you can help land this and port it to the WordPress 5.8 branch.

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me 👍 I'm going to commit it.

@jorgefilipecosta
Copy link
Member

Committed on 6bd5962 this PR can be closed :)

@desrosj desrosj closed this Jul 9, 2021
@oandregal oandregal deleted the fix/empty-sets-for-duotone-and-units branch July 9, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants