Skip to content

Conversation

@oandregal
Copy link
Member

Fixes https://core.trac.wordpress.org/ticket/53175#comment:34

Steps to reproduce:

  • Use a WordPress environment with PHP 8.
  • Activate the debug logs.
  • Set error_reporting( -1 ); at the head of load-styles.php.
  • Visit /wp-admin/load-styles.php?load=wp-components

The expected result is that the styles load and that there's no message in the log.

Previous to this change, the styles won't load and you'll see this error in the log Fatal error: Uncaught Error: Undefined constant "WP_CONTENT_DIR".

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Closing in favor of #1325, which seems like a better option :)

@oandregal oandregal deleted the fix/load-styles-php-8 branch June 2, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants