Combine CSS from Site Health with Privacy Settings#1266
Combine CSS from Site Health with Privacy Settings#1266laras126 wants to merge 4 commits intoWordPress:masterfrom
Conversation
|
Hi @laras126! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
I took a few screenshots of Site Health & Privacy (both tabs) at 3 sizes (960, 650, 400) & ran them through a diff script - mostly everything is similar, but it did highlight some differences. ✅ First in Privacy, as you mentioned, both pages are offset by 8px — I think this is a good change, it evens out the header visually. ✅ Privacy policy (same offset non-issue)
✅ Site Health Info: no change
|
ryelle
force-pushed
the
ticket/52429-combine-privacy-site-health-css
branch
from
f339cb3 to
454cbd2
Compare
|
Committed in r51025 🎉 |
2 participants
For declaration blocks in site-health.css that are duplicates of those for Privacy Settings in edit.css, add the selectors from site-health.css to the ruleset in edit.css to combine these duplicate styles.
There were two areas with inconsistency that I changed when moving the selectors:
user-select: autoto.privacy-settings-accordion-trigger.health-check-title-sectionvs. only text-alignpadding-top: 8pxto.privacy-settings-title-sectionto match that of Site HealthTrac ticket: https://core.trac.wordpress.org/ticket/52429
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.