Query: Prevent fatal TypeError when taxonomy query var is an array#11269
Query: Prevent fatal TypeError when taxonomy query var is an array#11269dan-zakirov wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
When a URL contains array-style GET parameters for a hierarchical taxonomy (e.g. ?category_name[]=foo), wp_basename() receives an array instead of a string, causing a fatal TypeError on PHP 8+. Added is_string() check before calling wp_basename() on the taxonomy query var value. The existing is_array() check on the next line already handles array values correctly, so this change only prevents the crash. Adds a unit test to verify the query completes without a TypeError when a hierarchical taxonomy query var is passed as an array. Props patricedefago. Fixes #64870.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
When a URL contains array-style GET parameters for a hierarchical taxonomy (e.g.
?product_cat[]=clothingor?category_name[]=foo),wp_basename()receives an array instead of a string. This causes a fatalTypeErroron PHP 8+ becauseurlencode()insidewp_basename()only accepts strings.Changes
is_string()check before callingwp_basename()on the taxonomy query var value inWP_Query::parse_tax_query().is_array()check on the next line already handles array values correctly, so this change only prevents the fatal crash without altering query behavior.TypeErrorwhen a hierarchical taxonomy query var is passed as an array.Trac ticket: https://core.trac.wordpress.org/ticket/64870
Props patricedefago.
Fixes #64870.