52826 wp getimagesize #1121
Closed
52826 wp getimagesize #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
force-pushed
the
52826-wp-getimagesize
branch
from
3471626 to
9b9d1f4
Compare
|
|
||
| public function test_get_jpeg_with_meta_data_via_stream() { | ||
| // wp_read_image_metadata gets the meta data via wp_getimagesize(). | ||
| $out = wp_read_image_metadata( 'wptestmediawpgetimagesize://Tests_Media_WpGetimagesize/exif.jpg' ); |
Contributor
There was a problem hiding this comment.
@peterwilsoncc The failure here is due to WP_Test_Stream not supporting seeking. Discovered by adding this into the test:
var_dump( getimagesize( 'wptestmediawpgetimagesize://Tests_Media_WpGetimagesize/exif.jpg' ) );which returns the following:
getimagesize(): stream does not support seeking
Contributor
Author
There was a problem hiding this comment.
Thanks so much. I'll put it in without tests and reach out to a few plugin developers to request manual testing.
If the test class can be set up to support seeking then the tests can be added as part of that.
Thanks again boss!
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://core.trac.wordpress.org/ticket/52826
trying to write some tests for this, maybe unsuccessfully.