-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix: Prefix/suffix for new site slug input does not appear correctly on RTL #10612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
I noticed that |
|
Review from Gemini: The changes in Review Findings:
Nit-picks:
Conclusion: The changes look good and follow WordPress core standards. The logic is sound, and the styling update is robust. Verdict: Approved. |
…order when RTL locale is active. Developed in #10612 Props geminorum, johnjamesjacoby, westonruter. See #49949. Fixes #64381. git-svn-id: https://develop.svn.wordpress.org/trunk@61365 602fd350-edb4-49c9-b593-d223f7449a82
…order when RTL locale is active. Developed in WordPress/wordpress-develop#10612 Props geminorum, johnjamesjacoby, westonruter. See #49949. Fixes #64381. Built from https://develop.svn.wordpress.org/trunk@61365 git-svn-id: http://core.svn.wordpress.org/trunk@60677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…order when RTL locale is active. Developed in WordPress/wordpress-develop#10612 Props geminorum, johnjamesjacoby, westonruter. See #49949. Fixes #64381. Built from https://develop.svn.wordpress.org/trunk@61365 git-svn-id: https://core.svn.wordpress.org/trunk@60677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Prefix/suffix for new site slug input does not appear correctly on RTL
Trac ticket: https://core.trac.wordpress.org/ticket/64381
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.