Block Processor: Remove use of NumberFormatter from test suite. #10576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Block Processor tests call `NumberFormatter` for generating its error messages, but in environments lacking the `intl` extension this led to crashes while running the tests. This patch reworks the tests so that they avoid calling `NumberFormatter` so that the tests run on more diverse setups.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
approved these changes
Dec 1, 2025
pento
pushed a commit
that referenced
this pull request
Dec 1, 2025
The Block Processor tests call `NumberFormatter` for generating its error messages, but in environments lacking the `intl` extension this led to crashes while running the tests. This patch reworks the tests so that they avoid calling `NumberFormatter` so that the tests run on more diverse setups. Developed in #10576 Discussed in https://core.trac.wordpress.org/ticket/64329 Follow-up to [60939]. Props desrosj, ellatrix, peterwilsoncc, westonruter. See #64329. git-svn-id: https://develop.svn.wordpress.org/trunk@61342 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 1, 2025
The Block Processor tests call `NumberFormatter` for generating its error messages, but in environments lacking the `intl` extension this led to crashes while running the tests. This patch reworks the tests so that they avoid calling `NumberFormatter` so that the tests run on more diverse setups. Developed in WordPress/wordpress-develop#10576 Discussed in https://core.trac.wordpress.org/ticket/64329 Follow-up to [60939]. Props desrosj, ellatrix, peterwilsoncc, westonruter. See #64329. Built from https://develop.svn.wordpress.org/trunk@61342 git-svn-id: http://core.svn.wordpress.org/trunk@60654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Dec 1, 2025
The Block Processor tests call `NumberFormatter` for generating its error messages, but in environments lacking the `intl` extension this led to crashes while running the tests. This patch reworks the tests so that they avoid calling `NumberFormatter` so that the tests run on more diverse setups. Developed in WordPress/wordpress-develop#10576 Discussed in https://core.trac.wordpress.org/ticket/64329 Follow-up to [60939]. Props desrosj, ellatrix, peterwilsoncc, westonruter. See #64329. Built from https://develop.svn.wordpress.org/trunk@61342 git-svn-id: https://core.svn.wordpress.org/trunk@60654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-64329
The Block Processor tests call
NumberFormatterfor generating its error messages, but in environments lacking theintlextension this led to crashes while running the tests.This patch reworks the tests so that they avoid calling
NumberFormatterso that the tests run on more diverse setups.