Notes: comment_count field is unintentionally incremented when note are resolved or reopened #10572
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@hbhalodia Thanks for the PR! Can you add a unit test? diff --git a/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php b/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php
index 3436934845..07c75d9871 100644
--- a/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php
+++ b/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php
@@ -46,6 +46,42 @@ class Tests_Comment_wpUpdateCommentCountNow extends WP_UnitTestCase {
remove_filter( 'pre_wp_update_comment_count_now', array( $this, '_return_100' ) );
}
+ /**
+ * @ticket 64325
+ */
+ public function test_only_approved_regular_comments_are_counted() {
+ $post_id = self::factory()->post->create();
+
+ self::factory()->comment->create(
+ array(
+ 'comment_post_ID' => $post_id,
+ 'comment_approved' => 0,
+ )
+ );
+ self::factory()->comment->create(
+ array(
+ 'comment_post_ID' => $post_id,
+ 'comment_approved' => 1,
+ )
+ );
+ self::factory()->comment->create(
+ array(
+ 'comment_post_ID' => $post_id,
+ 'comment_type' => 'note',
+ 'comment_approved' => 0,
+ )
+ );
+ self::factory()->comment->create(
+ array(
+ 'comment_post_ID' => $post_id,
+ 'comment_type' => 'note',
+ 'comment_approved' => 1,
+ )
+ );
+ $this->assertTrue( wp_update_comment_count_now( $post_id ) );
+ $this->assertSame( '1', get_comments_number( $post_id ) );
+ }
+
public function _return_100() {
return 100;
} |
|
Yes, on it. Will add the test. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I think this is the best approach.
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
I'm surprised this wasn't caught earlier. 🙂
|
Nice catch! |
5 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64325
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.