Abilities API: Use stricter doing_action check when registering
#10452
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @gziolo, looks great!
| // Fire the init hook to allow test ability category registration. | ||
| do_action( 'wp_abilities_api_categories_init' ); | ||
| wp_register_ability_category( | ||
| 'math', | ||
| array( | ||
| 'label' => 'Math', | ||
| 'description' => 'Mathematical operations and calculations.', | ||
| ) | ||
| ); | ||
|
|
There was a problem hiding this comment.
It isn’t mandatory at this level.
There was a problem hiding this comment.
Then remove wp_unregister_ability_category( 'math' ); from tear_down method.
Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82
|
Committed at fd41ccd. |
4 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64098
Follow-up for #9410.
Raised by @JasonTheAdams and @felixarntz in WordPress/abilities-api#126 (comment):
Although the code modifications were simple, getting the unit tests to pass was quite an adventure. I'm still not entirely convinced I took the most elegant approach for simulating the proper conditions, but my focus was to make the tests pass with the minimal set of changes necessary.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.