Abilities API: code quality improvements #10431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
force-pushed
the
fix/abilities-api
branch
from
59e2b7d to
0cd5392
Compare
pento
pushed a commit
that referenced
this pull request
Oct 29, 2025
…allback validation Code quality changes included: - Expands `annotations` parameter documentation with detailed descriptions for readonly, destructive, and idempotent properties. - Standardizes type order from `null|bool` to `bool|null` per coding standards. - Adds validation check to ensure permission callback is callable before invocation. Developed in #10431. Follow-up for [61067], [61032]. See #64134. git-svn-id: https://develop.svn.wordpress.org/trunk@61086 602fd350-edb4-49c9-b593-d223f7449a82
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 29, 2025
…allback validation Code quality changes included: - Expands `annotations` parameter documentation with detailed descriptions for readonly, destructive, and idempotent properties. - Standardizes type order from `null|bool` to `bool|null` per coding standards. - Adds validation check to ensure permission callback is callable before invocation. Developed in WordPress/wordpress-develop#10431. Follow-up for [61067], [61032]. See #64134. Built from https://develop.svn.wordpress.org/trunk@61086 git-svn-id: http://core.svn.wordpress.org/trunk@60422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
Author
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 29, 2025
…allback validation Code quality changes included: - Expands `annotations` parameter documentation with detailed descriptions for readonly, destructive, and idempotent properties. - Standardizes type order from `null|bool` to `bool|null` per coding standards. - Adds validation check to ensure permission callback is callable before invocation. Developed in WordPress/wordpress-develop#10431. Follow-up for [61067], [61032]. See #64134. Built from https://develop.svn.wordpress.org/trunk@61086 git-svn-id: https://core.svn.wordpress.org/trunk@60422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64134
Improves annotations documentation and add permission callback validation:
@annotationsparameter documentation with detailed descriptions for readonly,destructive, and idempotent properties.
null|booltobool|nullper coding standards.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.