Alternative: extra changes to Genericons #10427

sabernhardt · 2025-10-28T07:34:48Z

This is a superset of #7452

Alternative:
In addition to removing the EOT, filter, and various hacks, this includes three extra changes to consider.

Removes the TTF and SVG src references for all four themes.
Removes all prefixes from transform in the rotate and flip classes available in Twenty Sixteen.
Edits the values for prefixed transition properties in Twenty Fifteen and Twenty Sixteen.

Props: metodiew

Trac 62128

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

If these are retained, they should be wrapped in quotes: Automattic/Genericons#83

…or each `genericon-` class

…ass" This reverts commit 6e452a6.

…t/wordpress-develop into Genericons-additional

…bernhardt/wordpress-develop into Genericons-additional" This reverts commit a640cde, reversing changes made to 3d3181c.

github-actions · 2025-10-28T07:34:57Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt, westonruter, mukesh27, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-10-28T07:58:46Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

westonruter · 2025-10-28T15:18:36Z

src/wp-content/themes/twentythirteen/genericons/genericons.css



 /**
- * The font was graciously generated by Font Squirrel (http://www.fontsquirrel.com). We love those guys.


No more love? 🫶

💔😢
I removed that sentence for WordPress guidelines, but Genericons is from Automattic. I'll leave it out for now because "graciously" should be enough.

src/wp-content/themes/twentythirteen/genericons/genericons.css

src/wp-content/themes/twentyfourteen/genericons/genericons.css

westonruter · 2025-10-28T15:24:44Z

src/wp-content/themes/twentyfifteen/genericons/genericons.css

-    src: url('Genericons.eot');
-}
-
+/* When the font is base64 encoded, cross-site embedding works in Firefox */


Maybe this comment should just be removed now? It seems it was specifically here because of the previous four lines. It seems unnecessary now, since it's not contrasting with anything.

Suggested change

/* When the font is base64 encoded, cross-site embedding works in Firefox */

The way I read the full comment block, both IE9 and Firefox (at that time) required encoding the WOFF. It gave me a reason not to suggest replacing it with the external src URL.

That said, I do not mind removing the entire comment.

westonruter · 2025-10-28T15:25:08Z

src/wp-content/themes/twentysixteen/genericons/genericons.css

-   IE9 uses WOFF which is base64 encoded to allow cross-site embedding.
-   So unfortunately, IE9 will throw a console error, but it'll still work.
-   When the font is base64 encoded, cross-site embedding works in Firefox */
+/* When the font is base64 encoded, cross-site embedding works in Firefox */


Suggested change

/* When the font is base64 encoded, cross-site embedding works in Firefox */

Co-authored-by: Weston Ruter <[email protected]>

mukeshpanchal27 · 2025-10-29T13:13:21Z

src/wp-content/themes/twentyfifteen/genericons/genericons.css

-
-@font-face {
-    font-family: 'Genericons';
-    src: url('Genericons.eot');


Remove the Genericons.eot file if we don't need it.

Is there any way we can check how many sites use child themes?

I'm not aware of a way to count the sites.

I have built a number of sites using child themes of three of these four. I also have dequeued the Genericons stylesheet more than once, but then the site was not using a font for its icons. Someone else could have taken another step and created their own version of the Genericons stylesheet.

westonruter · 2025-10-29T14:58:29Z

Would these changes be proposed upstream at https://github.com/Automattic/Genericons also?

sabernhardt

Automattic/Genericons#109 and Trac 43195 note that the zero-second transition-delay value is default anyway.

Props: manuel_84, GaryJ, SergeyBiryukov

src/wp-content/themes/twentyfifteen/genericons/genericons.css

src/wp-content/themes/twentysixteen/genericons/genericons.css

Props: manuel_84, GaryJ, SergeyBiryukov

sabernhardt · 2025-10-29T17:44:42Z

Would these changes be proposed upstream at https://github.com/Automattic/Genericons also?

The transition-delay issue was reported already, and I updated the PR accordingly.

Additional changes could be suggested upstream, but I doubt it will be updated anymore. Automattic/Genericons#105 and Automattic/Genericons#106 encouraged using Genericons Neue or Social Logos instead in 2016, and the last update to this project's repository was five years ago.

peterwilsoncc

Thanks for working on this, I've confirmed it prevents the font from loading twice in Firefox.

As noted by @mukeshpanchal27, the font files can be removed with the change to only include the encoded woff font. (eot, svg and ttf)

I might be having a silly but I can't actually see where the icons are used in 2016. Can I get a logic check on that?

In the other themes, the font is always been used when the stylesheet is included so I think leaving the file base64 encoded inline is good, it avoids an HTTP request.

sabernhardt · 2025-10-30T00:46:19Z

the font files can be removed with the change to only include the encoded woff font. (eot, svg and ttf)

I prefer not to delete any files.

Child themes and plugins can replace the stylesheet with one that still contains references to any of the font files (likely for reducing CSS). The Genericons readme files even describe creating your own styles.
T13 and T14 have included the OTF as part of the package, and the stylesheet did not use that.

I might be having a silly but I can't actually see where the icons are used in 2016

T16 uses the icons in several places, anywhere the content value starts with "\f. That includes navigation toggle buttons and arrow links, social navigation, etc.

peterwilsoncc · 2025-10-30T21:24:33Z

I prefer not to delete any files.

Child themes and plugins can replace the stylesheet with one that still contains references to any of the font files (likely for reducing CSS). The Genericons readme files even describe creating your own styles.

T13 and T14 have included the OTF as part of the package, and the stylesheet did not use that.

OK, I'm happy to follow your advice on this as you work on the bundled themes heaps more than I do.

westonruter

@sabernhardt I'm happy to commit this for you if you like.

sabernhardt · 2025-10-31T18:36:35Z

I'm happy to commit this for you if you like.

Thanks!

This updates Twenty Thirteen, Twenty Fourteen, Twenty Fifteen, and Twenty Sixteen as follows: * Remove legacy Internet Explorer support by deleting EOT file rules from CSS. * Remove IE hacks from the version included in Twenty Thirteen and Twenty Fourteen. * Remove `filter` rules from the CSS included in Twenty Sixteen. * Remove the TTF and SVG `src` references for all four themes. * Remove all prefixes from transform in the rotate and flip classes available in Twenty Sixteen. * Edit the values for prefixed transition properties in Twenty Fifteen and Twenty Sixteen. * Update CSS comments. Developed in #10427 Props sabernhardt, metodiew, peterwilsoncc, mukesh27, westonruter. See #56699, #58836. Fixes #62128. git-svn-id: https://develop.svn.wordpress.org/trunk@61109 602fd350-edb4-49c9-b593-d223f7449a82

westonruter · 2025-11-01T02:41:42Z

Committed in r61109.

This updates Twenty Thirteen, Twenty Fourteen, Twenty Fifteen, and Twenty Sixteen as follows: * Remove legacy Internet Explorer support by deleting EOT file rules from CSS. * Remove IE hacks from the version included in Twenty Thirteen and Twenty Fourteen. * Remove `filter` rules from the CSS included in Twenty Sixteen. * Remove the TTF and SVG `src` references for all four themes. * Remove all prefixes from transform in the rotate and flip classes available in Twenty Sixteen. * Edit the values for prefixed transition properties in Twenty Fifteen and Twenty Sixteen. * Update CSS comments. Developed in WordPress/wordpress-develop#10427 Props sabernhardt, metodiew, peterwilsoncc, mukesh27, westonruter. See #56699, #58836. Fixes #62128. Built from https://develop.svn.wordpress.org/trunk@61109 git-svn-id: http://core.svn.wordpress.org/trunk@60445 1a063a9b-81f0-0310-95a4-ce76da25c4cd

This updates Twenty Thirteen, Twenty Fourteen, Twenty Fifteen, and Twenty Sixteen as follows: * Remove legacy Internet Explorer support by deleting EOT file rules from CSS. * Remove IE hacks from the version included in Twenty Thirteen and Twenty Fourteen. * Remove `filter` rules from the CSS included in Twenty Sixteen. * Remove the TTF and SVG `src` references for all four themes. * Remove all prefixes from transform in the rotate and flip classes available in Twenty Sixteen. * Edit the values for prefixed transition properties in Twenty Fifteen and Twenty Sixteen. * Update CSS comments. Developed in WordPress/wordpress-develop#10427 Props sabernhardt, metodiew, peterwilsoncc, mukesh27, westonruter. See #56699, #58836. Fixes #62128. Built from https://develop.svn.wordpress.org/trunk@61109 git-svn-id: https://core.svn.wordpress.org/trunk@60445 1a063a9b-81f0-0310-95a4-ce76da25c4cd

sabernhardt added 30 commits September 27, 2024 10:00

Removing EOT, IE hacks and "We" comment from T13 and T14 CSS

39820d0

Removing EOT from T15 and T16 CSS

762a69c

Delete filter property rules in T16

17a6c9a

If these are retained, they should be wrapped in quotes: Automattic/Genericons#83

Merge branch 'WordPress:trunk' into Genericons-IE

ffe539f

Merge branch 'WordPress:trunk' into Genericons-IE

12a2fe2

Merge branch 'WordPress:trunk' into Genericons-IE

44bf26b

T13 version string

4895664

T14 version string

527b54b

T15 version string

21e5bd2

T16 version string

74eef3a

Update version strings for Genericons

f29e2c9

Merge branch 'WordPress:trunk' into Genericons-IE

681136c

Merge branch 'WordPress:trunk' into Genericons-IE

2133301

Update version string in twentythirteen_custom_header_fonts()

01bbeb8

Remove -webkit-min-device-pixel-ratio hack from Twenty Fifteen

28c9a1b

Remove -webkit-min-device-pixel-ratio hack from Twenty Sixteen

ef83703

T16: remove all prefixes from transform

77788a6

T16: add unit and leading zero to transition values

8fe5a07

T15: add unit and leading zero to transition values

77beffe

T16: remove speak: never and add empty alternative content values f…

4cd3c21

…or each `genericon-` class

T15: remove speak: never and add empty alternative content values f…

8e70ec0

…or each `genericon-` class

T14: add empty alternative content values for each genericon- class

5725f9b

T13: add empty alternative content values for each genericon- class

cab036b

T16: remove TTF and SVG src fallbacks

eb402d3

T15: remove TTF and SVG src fallbacks

e8c591d

T14: remove TTF and SVG src fallbacks

584e8bc

T13: remove TTF and SVG src fallbacks

c683853

Add empty alternative content values for each genericon- class

6e452a6

T16: remove TTF and SVG src fallbacks

52f1540

T15: remove TTF and SVG src fallbacks

fab0575

sabernhardt added 7 commits October 27, 2025 00:41

T14: remove TTF and SVG src fallbacks

eaeee7e

T13: remove TTF and SVG src fallbacks

29c7128

Revert "Add empty alternative content values for each genericon- cl…

3d3181c

…ass" This reverts commit 6e452a6.

Merge branch 'Genericons-additional' of https://github.com/sabernhard…

a640cde

…t/wordpress-develop into Genericons-additional

Revert "Merge branch 'Genericons-additional' of https://github.com/sa…

f1924d3

…bernhardt/wordpress-develop into Genericons-additional" This reverts commit a640cde, reversing changes made to 3d3181c.

T14: remove extra empty lines at end

6f5ee46

T14: remove extra empty lines at end

ed78342

westonruter reviewed Oct 28, 2025

View reviewed changes

sabernhardt and others added 2 commits October 28, 2025 11:33

T13: HTTPS for Font Squirrel link

f22cc79

Co-authored-by: Weston Ruter <[email protected]>

T14: HTTPS for Font Squirrel link

35a13a4

Co-authored-by: Weston Ruter <[email protected]>

mukeshpanchal27 reviewed Oct 29, 2025

View reviewed changes

sabernhardt commented Oct 29, 2025

View reviewed changes

src/wp-content/themes/twentyfifteen/genericons/genericons.css Outdated Show resolved Hide resolved

src/wp-content/themes/twentysixteen/genericons/genericons.css Outdated Show resolved Hide resolved

Remove 0s value for transition-delay

908e3f7

Props: manuel_84, GaryJ, SergeyBiryukov

peterwilsoncc reviewed Oct 29, 2025

View reviewed changes

peterwilsoncc approved these changes Oct 30, 2025

View reviewed changes

westonruter approved these changes Oct 31, 2025

View reviewed changes

mukeshpanchal27 approved these changes Oct 31, 2025

View reviewed changes

westonruter closed this Nov 1, 2025

sabernhardt deleted the Genericons-additional branch November 1, 2025 02:45



		/**
		* The font was graciously generated by Font Squirrel (http://www.fontsquirrel.com). We love those guys.

Alternative: extra changes to Genericons #10427

Alternative: extra changes to Genericons #10427

Uh oh!

Conversation

sabernhardt commented Oct 28, 2025 • edited by westonruter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 28, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

westonruter commented Oct 29, 2025

Uh oh!

sabernhardt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sabernhardt commented Oct 29, 2025

Uh oh!

peterwilsoncc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sabernhardt commented Oct 30, 2025

Uh oh!

peterwilsoncc commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

westonruter left a comment

Choose a reason for hiding this comment

Uh oh!

sabernhardt commented Oct 31, 2025

Uh oh!

westonruter commented Nov 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sabernhardt commented Oct 28, 2025 •

edited by westonruter

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading

peterwilsoncc left a comment •

edited

Loading

peterwilsoncc commented Oct 30, 2025 •

edited

Loading