-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Block Bindings: Update core/post-data source to work with Navigation blocks
#10305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings: Update core/post-data source to work with Navigation blocks
#10305
Conversation
jeryj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this fix to my wordpress e2e environment and it allowed the failing Update page slug and verify frontend reflects change test step to pass. So, this fix does work for what we need it to. Thank you!
Co-authored-by: Carlos Bravo <[email protected]>
Co-authored-by: Carlos Bravo <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Failing CI jobs seem to be unrelated (and present on all recently filed PRs); they seem to be related to the Gutenberg build system (some TypeScript build error specifically?) I've asked in WordPress Slack. |
Carry over changes to the
core/post-datasource from WordPress/gutenberg#72165.Modeled after #9299.
Trac ticket: https://core.trac.wordpress.org/ticket/64107
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.