Skip to content

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Oct 8, 2025

This commit backports to core the php changes required for the fitText implementation which was worked on at WordPress/gutenberg#71904. It can be merged even before the packages are updated because unless the fitText support is used nothing happens.

Ticket: https://core.trac.wordpress.org/ticket/64119

@jorgefilipecosta jorgefilipecosta added the php Pull requests that update php code label Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Changes look good to me.

Do we need to wait for package backport?

@t-hamano
Copy link
Contributor

@jorgefilipecosta To track this PR, I'd appreciate it if you submit a core ticket with the gutenberg-merge keyword.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorgefilipecosta, mukesh27, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jorgefilipecosta
Copy link
Member Author

@jorgefilipecosta To track this PR, I'd appreciate it if you submit a core ticket with the gutenberg-merge keyword.

Thank you for the reminder, track ticket is available at https://core.trac.wordpress.org/ticket/64119,

@jorgefilipecosta
Copy link
Member Author

jorgefilipecosta commented Oct 20, 2025

Thanks for the PR. Changes look good to me.

Do we need to wait for package backport?

Hi @mukeshpanchal27, we don't need to wait it can be committed after or before the package update. Thank you a lot for the review ☺️

This commit backports to core the php changes required for the fitText implementation which was worked on at WordPress/gutenberg#71904.
It can be merged even before the packages are updated because unless the fitText support is used nothing happens.
@jorgefilipecosta jorgefilipecosta force-pushed the add/enqueue-fit-text-frontend-assets branch from 9c5cac6 to bdf52d3 Compare October 21, 2025 10:56
@cbravobernal
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

php Pull requests that update php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants