-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Block editor: Conditionally enqueue front end assets for fitText. #10190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block editor: Conditionally enqueue front end assets for fitText. #10190
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Changes look good to me.
Do we need to wait for package backport?
|
@jorgefilipecosta To track this PR, I'd appreciate it if you submit a core ticket with the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thank you for the reminder, track ticket is available at https://core.trac.wordpress.org/ticket/64119, |
Hi @mukeshpanchal27, we don't need to wait it can be committed after or before the package update. Thank you a lot for the review |
This commit backports to core the php changes required for the fitText implementation which was worked on at WordPress/gutenberg#71904. It can be merged even before the packages are updated because unless the fitText support is used nothing happens.
9c5cac6 to
bdf52d3
Compare
This commit backports to core the php changes required for the fitText implementation which was worked on at WordPress/gutenberg#71904. It can be merged even before the packages are updated because unless the fitText support is used nothing happens.
Ticket: https://core.trac.wordpress.org/ticket/64119