Skip to content

Unit test: is_post_status_viewable() improvement #10164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mukeshpanchal27 wants to merge 3 commits into from
Closed

Unit test: is_post_status_viewable() improvement #10164

mukeshpanchal27 wants to merge 3 commits into from

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Oct 6, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/63167

  • Converted the data_custom_post_statuses and data_built_unregistered_in_status_types data provider methods to static, slight performance improvement.
  • Added the @covers is_post_status_viewable annotation to the test class to explicitly declare the function under test.
  • Improved the readability of the test data arrays in data_custom_post_statuses by replacing numeric indexes with descriptive string keys for each test case.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 6, 2025 12:52
@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SergeyBiryukov
Copy link
Member

SergeyBiryukov commented Nov 7, 2025

Thanks for the PR! Merged in r61170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mukeshpanchal27 @SergeyBiryukov @swissspidy