Skip to content

Conversation

@andrewserong
Copy link
Contributor

@andrewserong andrewserong commented Oct 2, 2025

This PR builds on what was proposed in #9406, but adds tests and fixes up an issue where the former PR didn't yet update the valid settings array.

Trac ticket: https://core.trac.wordpress.org/ticket/63799#ticket

This PR brings the changes from the following Gutenberg PR to core: WordPress/gutenberg#67544 for support for border radius presets.

Changes include:

  • definitions of presets settings for theme.json
  • CSS var settings for style engine

Testing instructions:

Check that the PHP tests pass, but you can also run these tests locally if you so desire:

npm run test:php -- --filter Tests_wpStyleEngine
npm run test:php -- --filter Tests_Theme_wpThemeJson

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, andrewserong, ramonopoly, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked against WordPress/gutenberg#67544 (which was already tested in context)

LGTM

@andrewserong
Copy link
Contributor Author

Thanks folks! I'll commit this tomorrow 👍

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60892
GitHub commit: dc9dc24

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants