HTML API: Rely on assertEqualHTML in wp_rel_nofollow() tests.

dmsnell · dmsnell · commit fb9220f2819c · 2025-10-19T00:32:32.000Z
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality checks with semantic checks via `assertEqualHTML()` for more-direct assertions. Developed in #9251 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 git-svn-id: https://develop.svn.wordpress.org/trunk@60974 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/tests/phpunit/tests/formatting/wpRelNofollow.php b/tests/phpunit/tests/formatting/wpRelNofollow.php
@@ -12,25 +12,25 @@ class Tests_Formatting_wpRelNofollow extends WP_UnitTestCase {
 	 */
 	public function test_add_no_follow() {
 		$content  = '<p>This is some cool <a href="/">Code</a></p>';
-		$expected = '<p>This is some cool <a href=\"/\" rel=\"nofollow\">Code</a></p>';
-		$this->assertSame( $expected, wp_rel_nofollow( $content ) );
+		$expected = '<p>This is some cool <a href="/" rel="nofollow">Code</a></p>';
+		$this->assertEqualHTML( $expected, stripslashes( wp_rel_nofollow( $content ) ) );
 	}
 
 	/**
 	 * @ticket 9959
 	 */
 	public function test_convert_no_follow() {
 		$content  = '<p>This is some cool <a href="/" rel="weird">Code</a></p>';
-		$expected = '<p>This is some cool <a href=\"/\" rel=\"weird nofollow\">Code</a></p>';
-		$this->assertSame( $expected, wp_rel_nofollow( $content ) );
+		$expected = '<p>This is some cool <a href="/" rel="weird nofollow">Code</a></p>';
+		$this->assertEqualHTML( $expected, stripslashes( wp_rel_nofollow( $content ) ) );
 	}
 
 	/**
 	 * @ticket 11360
 	 * @dataProvider data_wp_rel_nofollow
 	 */
 	public function test_wp_rel_nofollow( $input, $output, $expect_deprecation = false ) {
-		$this->assertSame( wp_slash( $output ), wp_rel_nofollow( $input ) );
+		$this->assertEqualHTML( $output, stripslashes( wp_rel_nofollow( $input ) ) );
 	}
 
 	public function data_wp_rel_nofollow() {
@@ -80,7 +80,7 @@ public function data_wp_rel_nofollow() {
 
 	public function test_append_no_follow_with_valueless_attribute() {
 		$content  = '<p>This is some cool <a href="demo.com" download rel="hola">Code</a></p>';
-		$expected = '<p>This is some cool <a href=\"demo.com\" download rel=\"hola nofollow\">Code</a></p>';
-		$this->assertSame( $expected, wp_rel_nofollow( $content ) );
+		$expected = '<p>This is some cool <a href="demo.com" download rel="hola nofollow">Code</a></p>';
+		$this->assertEqualHTML( $expected, stripslashes( wp_rel_nofollow( $content ) ) );
 	}
 }
