A few test nitpicks.

peterwilsoncc · peterwilsoncc · commit e8b2b2c1fa40 · 2024-09-14T09:54:00.000+10:00
diff --git a/tests/phpunit/tests/block-template.php b/tests/phpunit/tests/block-template.php
@@ -467,7 +467,7 @@ public function test_get_block_template_from_registry() {
 
 		$template = get_block_template( 'block-theme//test-template' );
 
-		$this->assertEquals( 'Test Template', $template->title );
+		$this->assertSame( 'Test Template', $template->title );
 
 		wp_unregister_block_template( $template_name );
 	}
diff --git a/tests/phpunit/tests/block-templates/WpBlockTemplatesRegistry.php b/tests/phpunit/tests/block-templates/WpBlockTemplatesRegistry.php
@@ -48,7 +48,7 @@ public function test_register_template_invalid_name() {
 		$this->setExpectedIncorrectUsage( 'WP_Block_Templates_Registry::register' );
 		$result = self::$registry->register( $template_name );
 
-		$this->assertWPError( $result );
+		$this->assertWPError( $result, 'Template registration is expected to trigger an error.' );
 		$this->assertSame( 'template_name_no_string', $result->get_error_code(), 'Error code mismatch.' );
 		$this->assertSame( 'Template names must be strings.', $result->get_error_message(), 'Error message mismatch.' );
 	}
@@ -68,7 +68,7 @@ public function test_register_template_invalid_name_uppercase() {
 		$this->setExpectedIncorrectUsage( 'WP_Block_Templates_Registry::register' );
 		$result = self::$registry->register( $template_name );
 
-		$this->assertWPError( $result );
+		$this->assertWPError( $result, 'Template registration is expected to trigger an error.' );
 		$this->assertSame( 'template_name_no_uppercase', $result->get_error_code(), 'Error code mismatch.' );
 		$this->assertSame( 'Template names must not contain uppercase characters.', $result->get_error_message(), 'Error message mismatch.' );
 	}
@@ -85,7 +85,7 @@ public function test_register_template_no_prefix() {
 		$this->setExpectedIncorrectUsage( 'WP_Block_Templates_Registry::register' );
 		$result = self::$registry->register( 'template-no-plugin', array() );
 
-		$this->assertWPError( $result );
+		$this->assertWPError( $result, 'Template registration is expected to trigger an error.' );
 		$this->assertSame( 'template_no_prefix', $result->get_error_code(), 'Error code mismatch.' );
 		$this->assertSame( 'Template names must contain a namespace prefix. Example: my-plugin//my-custom-template', $result->get_error_message(), 'Error message mismatch.' );
 	}
@@ -106,7 +106,7 @@ public function test_register_template_already_exists() {
 		$this->setExpectedIncorrectUsage( 'WP_Block_Templates_Registry::register' );
 		$result = self::$registry->register( $template_name );
 
-		$this->assertWPError( $result );
+		$this->assertWPError( $result, 'Template registration is expected to trigger an error.' );
 		$this->assertSame( 'template_already_registered', $result->get_error_code(), 'Error code mismatch.' );
 		$this->assertStringContainsString( 'Template "test-plugin//duplicate-template" is already registered.', $result->get_error_message(), 'Error message mismatch.' );
 
@@ -164,7 +164,7 @@ public function test_get_registered() {
 		$this->assertSame( 'Description of registered template', $registered_template->description, 'Template description mismatch.' );
 		$this->assertSame( 'plugin', $registered_template->source, "Template source should be 'plugin'." );
 		$this->assertSame( 'plugin', $registered_template->origin, "Template origin should be 'plugin'." );
-		$this->assertEquals( array( 'post', 'page' ), $registered_template->post_types, 'Template post types mismatch.' );
+		$this->assertSameSets( array( 'post', 'page' ), $registered_template->post_types, 'Template post types mismatch.' );
 		$this->assertSame( 'test-plugin', $registered_template->plugin, 'Plugin name mismatch.' );
 
 		self::$registry->unregister( $template_name );

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ public function test_get_block_template_from_registry() {`
`467`	`467`
`468`	`468`	`$template = get_block_template( 'block-theme//test-template' );`
`469`	`469`
`470`		`- $this->assertEquals( 'Test Template', $template->title );`
	`470`	`+ $this->assertSame( 'Test Template', $template->title );`
`471`	`471`
`472`	`472`	`wp_unregister_block_template( $template_name );`
`473`	`473`	`}`