-
Notifications
You must be signed in to change notification settings - Fork 83
Add safelisted properties to Custom CSS sanitizer #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safelisted properties to Custom CSS sanitizer #787
Conversation
ryelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions on some of the properties, but the rest are okay.
| array( | ||
| 'aspect-ratio', | ||
| 'background-blend-mode', | ||
| 'box-orient', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nonstandard property from a previous flexbox spec, is there a standard one that corresponds to it? flex-direction maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to use this for a progressive-enhancement for supported browsers, in combination with -webkit-line-clamp. Unfortunately flex-direction and others aren't a substitute. This totally isn't essential, more nice-to-have.
This little combo gives the ability to limit excerpts, use a nicer ellipsis display and get the Read More buttons all in the same position

|
@ryelle thanks for taking a look at this! I commented and pushed |
In building the WCUS 2022 website, there were a number of CSS properties I was hoping to use for broad-audience (
text-stroke) and progressive-enhancement (overscroll-behavior).