Simplify Docker DB setup (Remove HyperDB) #1568
Merged
+9
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of attempting to stream line WordCamp to use the WordPress.org HyperDB I've run into a case where it's probably easier to remove the HyperDB handling from the github codebase, than it is to workaround having part of it open-source verses the closed-source (DB configuration).
As HyperDB is not actually needed by WordCamp.org in local environments (There's only a singular Database/server) it might as well just be removed.
This might have some unexpected edgecases, as WordPress may upgrade the local-dev DB tables collation from
utf8mb4_general_citoutf8mb4_unicode_520_ciwhich we're not presently using on WordCamp.org (AFAIK), but this isn't likely to cause any compatibility issues between the two environments.