Fix blueprint and wporg asset deploys #734
Merged
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Dec 11, 2025
| if: github.ref_name == 'master' | ||
| env: | ||
| # Note: this action doesn't support BUILD_DIR so it pushes the raw readme.txt | ||
| IGNORE_OTHER_FILES: true |
Collaborator
Author
There was a problem hiding this comment.
This action is inconsistent in two ways
-
It doesn't support
BUILD_DIRso we can't point it to the correct directory of built files (according to our release logic). -
It attempts to deploy the un-built source files unless we specify
IGNORE_OTHER_FILESwhich would deploy and invalid release.
| - name: WordPress.org deploy | ||
| id: deploy | ||
| uses: 10up/action-wordpress-plugin-deploy@stable | ||
| if: startsWith( github.ref, 'refs/tags/' ) |
Collaborator
Author
There was a problem hiding this comment.
This action derives the release VERSION from the tag name so it can't run anywhere else but on tag builds.
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
blueprint.jsonis deployed to WP.orgassetsdirectory.Why?
Fixes #731.
How?
Note:
readme.txtof the latest release tag version before the tag has been created since that happens after merging the release pull request intomaster. I'm not 100% sure what WP-org does when the specified stable tag is actually not part of SVN.Testing Instructions
Screenshots or screencast
Changelog Entry