Don't URI encode the TOTP url for display. #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #710 Co-authored-by: fb656720 < 223508510 [email protected]>
kasparsd
added a commit
that referenced
this pull request
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #710 - Full props to @fb656720 for change.
What?
2FAS authenticator doesn't support the url-encoded format, while other authenticator apps appear to support this, it doesn't appear to be allowable by the standard.
Why?
How?
Avoids encoding the TOTP QR code url for display, by using
esc_url_raw()in the provider.URL is properly encoded for display at display time, and encoded properly for JS usage.
Testing Instructions
Screenshots or screencast
Changelog Entry
Fixed: TOTP QR Code not working with 2FAS authenticator.