This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Remove button border and fix outline variation padding inconsistencies #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-815
to
-818
| "bottom": { | ||
| "style": "solid", | ||
| "width": "1px" | ||
| }, |
Collaborator
There was a problem hiding this comment.
this makes a lot of sense, the element doesn't have an outlined variation
This was referenced Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative to #645 and #643, which closes #613. Makes the buttons the intended size across variations, while also removing the border (which made it harder to change colors).
This fix is applied to default and fossil variations for now; the others do not have varying button styles (yet) so the fix in default is inherited there.
Screenshots
