Try variable fonts as a means to reduce package size #603
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thank you Carolina, from what I tested it looks good.
|
Thank you for making this change! If my testing is showing accurately, these are looking similar to the previous ones to me. Just to confirm, do they look like the screenshots below to you as well? If so, this is ok to merge.
|
|
Yes, it is looking like the screenshots to me. I'm merging this one then. |
|
Thank you all! |
Description
Partial for #401.
By replacing the separate font files with a single variable font, the package size can be decreased somewhat, and the size of theme.json is decreased as well.
Testing Instructions
Test the typography preset that uses the updated font families:
Manrope
Fira code
Platypi
Vollkorn
Ysabeau Office
Check that any visual changes are acceptable, since there may be some minor differences in the two formats.
Conform that the correct font style settings are available in the Typography panel > Appearance