Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Update: Set correct footers and header to "News" blog templates #600

Merged
carolinan merged 3 commits into from
Oct 21, 2024
Merged

Update: Set correct footers and header to "News" blog templates #600

carolinan merged 3 commits into from
Oct 21, 2024

Conversation

@juanfra
Copy link
Member

@juanfra juanfra commented Oct 21, 2024

Description

Fixes #591

Screenshots

N/A

Testing Instructions

  • Open the site editor.
  • Edit the home template, archive, search results and single post templates to use the ones affected by this PR.
  • Confirm that the headers and footers match what was requested in the GH issue.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 21, 2024
@juanfra juanfra self-assigned this Oct 21, 2024
@github-actions
Copy link

github-actions bot commented Oct 21, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

carolinan commented Oct 21, 2024 •
edited
Loading

The header template part needs to be added to theme.json so that the label can be used in the Site Editor.
Right now the visible label is the file name: header-large-title:
image

@juanfra
Copy link
Member Author

juanfra commented Oct 21, 2024

Thank you for the heads-up Carolina! it was an oversight.

@carolinan
Copy link
Contributor

carolinan commented Oct 21, 2024

I believe the headers and footer matches the list in the issue.
Let's merge this since we are so close to RC1.

@carolinan carolinan merged commit 5473f18 into trunk Oct 21, 2024
4 checks passed
@juanfra juanfra deleted the update/headers branch October 21, 2024 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carolinan carolinan Awaiting requested review from carolinan

@beafialho beafialho Awaiting requested review from beafialho

Assignees

@juanfra juanfra

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set correct footers and header to "News" blog templates

3 participants

@juanfra @carolinan