Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@juanfra
Copy link
Member

@juanfra juanfra commented Oct 11, 2024

Description

Fixes #549

Updating the style variation and typography preset according to the request here

Screenshots

  • N/A

Testing Instructions

  1. Go to the site editor
  2. Pick the "Literata & Fira Sans" typographic preset and confirm the styles match the ones listed in the issue.

  1. Go to the site editor
  2. Pick the "Midnight" style variation and confirm the styles match the ones listed in the issue.

@juanfra juanfra self-assigned this Oct 11, 2024
@github-actions
Copy link

github-actions bot commented Oct 11, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra
Copy link
Member Author

juanfra commented Oct 14, 2024

Thank you Carolina!

The H6 already inherits the 200 font weight set on elements > heading.

Given the specificity of this, the heading styles are being overridden, and we need to set the H6.

@juanfra juanfra requested a review from carolinan October 14, 2024 08:59
@carolinan
Copy link
Contributor

Given the specificity of this, the heading styles are being overridden, and we need to set the H6.

I was able to confirm this, good catch.

@beafialho
Copy link
Contributor

Thank you, it's all looking good to me 👍

If it’s possible, can we remove Fira Sans Bold from the theme and whenever the Bold typography setting is selected and applied, it falls back to Fira Sans Medium? Mostly because Fira Sans Bold is appearing a bit harsh visually, probably because there’s no font smoothing, like there is on Figma.

I assume this isn't possible. If that's the case, it's ok, it's not a blocker.

@juanfra
Copy link
Member Author

juanfra commented Oct 14, 2024

Thank you all! as we discussed in Slack we keep the bold. I'm merging this.

@juanfra juanfra merged commit e4da8ad into trunk Oct 14, 2024
@juanfra juanfra deleted the update/midnight branch October 14, 2024 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Midnight: List of elements to adjust

4 participants