Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Try: Update morning & typography preset 5 #561

Merged
juanfra merged 13 commits into from
Oct 14, 2024
Merged

Try: Update morning & typography preset 5 #561

juanfra merged 13 commits into from
Oct 14, 2024

Conversation

@juanfra
Copy link
Member

@juanfra juanfra commented Oct 11, 2024 •
edited
Loading

Description

Fixes #548

Updating the style variation and typography preset according to the request here

Screenshots

  • N/A

Testing Instructions

  1. Go to the site editor
  2. Pick the "Literata & Ysabeau Office" typographic preset and confirm the styles match the ones listed in the issue.
  1. Go to the site editor
  2. Pick the "Morning" style variation and confirm the styles match the ones listed in the issue.

@juanfra juanfra self-assigned this Oct 11, 2024
@github-actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

carolinan
carolinan reviewed Oct 14, 2024
View reviewed changes
@juanfra
Copy link
Member Author

juanfra commented Oct 14, 2024

Thank you Carolina!

@juanfra juanfra requested a review from carolinan October 14, 2024 09:12
@carolinan
Copy link
Contributor

carolinan commented Oct 14, 2024

I think everything on the list is fixed, I am unsure of if the colors were meant to be removed, or if the issue was only for the typography?

@beafialho
Copy link
Contributor

beafialho commented Oct 14, 2024 •
edited
Loading

Thank you @juanfra for implementing the changes.

Regarding the colors, if we remove the specific color they still seem to show up with the correct link color when they are links, so I think that should be ok. The quote, as I described in the issue is expected to be the same color as the text, like you implemented, so let's leave it as well.

Everything looks good to me 🚀

@juanfra
Copy link
Member Author

juanfra commented Oct 14, 2024

Thank you for your reviews. I'm merging, then.

@juanfra juanfra merged commit 6e36b6f into trunk Oct 14, 2024
@juanfra juanfra deleted the update/morning branch October 14, 2024 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beafialho beafialho Awaiting requested review from beafialho

@carolinan carolinan Awaiting requested review from carolinan

Assignees

@juanfra juanfra

Labels

[Component] Style Variations [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Morning: List of elements to adjust

4 participants

@juanfra @carolinan @beafialho