Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@beafialho
Copy link
Contributor

This PR addresses #501 and adds an enhancement to the code. This is the intended look of the blocks worked on:

  • Improved letter spacing, font size and font weights

Captura de ecrã 2024-10-08, às 09 40 27

Captura de ecrã 2024-10-08, às 09 40 31

Captura de ecrã 2024-10-08, às 09 41 25

@beafialho beafialho requested review from carolinan and juanfra October 8, 2024 08:41
@github-actions
Copy link

github-actions bot commented Oct 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan
Copy link
Contributor

@beafialho All other presets and the combined variations are unchanged, is that correct?

@carolinan
Copy link
Contributor

I am seeing some duplicates, there are presets that set the cite to font size small and font weight 300, these can be removed since they now match theme.json.

@beafialho
Copy link
Contributor Author

Correct @carolinan, I only changed the default one. However, now that I tried it, the Evening variation should have the same the same settings, since the only thing varying is its colors.

@carolinan
Copy link
Contributor

I think I have found and removed all duplicate styles.

@carolinan
Copy link
Contributor

carolinan commented Oct 8, 2024

@juanfra Aside, I think we can remove all "fontStyle": "normal" since this is the default.
The only place where it is needed is in theme.json settings > typography > fontfamilies

@beafialho
Copy link
Contributor Author

Thank you for the help! Looking good 🚀

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me 🫡

@juanfra juanfra merged commit 6b6fb1d into trunk Oct 8, 2024
@juanfra juanfra deleted the quote-adjustments branch October 8, 2024 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants