-
Notifications
You must be signed in to change notification settings - Fork 126
Theme.json visual adjustments for quote, pullquote, cite & code block #517
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
@beafialho All other presets and the combined variations are unchanged, is that correct? |
|
I am seeing some duplicates, there are presets that set the cite to font size small and font weight 300, these can be removed since they now match theme.json. |
|
Correct @carolinan, I only changed the default one. However, now that I tried it, the Evening variation should have the same the same settings, since the only thing varying is its colors. |
|
I think I have found and removed all duplicate styles. |
|
@juanfra Aside, I think we can remove all |
|
Thank you for the help! Looking good 🚀 |
juanfra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good to me 🫡
This PR addresses #501 and adds an enhancement to the code. This is the intended look of the blocks worked on: