Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Midnight: Remove letter spacing from the post title block #515

Merged
juanfra merged 1 commit into from
Oct 8, 2024
Merged

Midnight: Remove letter spacing from the post title block #515

juanfra merged 1 commit into from
Oct 8, 2024

Conversation

@carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 8, 2024 •
edited
Loading

Description
This PR removes the letter spacing from the post title block for the midnight variation and typography preset 7.
The letter spacing on elements > heading was not removed, so the post title falls back to using letter-spacing: -0.02em;

Closes #512

Screenshots
After:
Screenshot of the default single template.

Screenshot of the News blog single post template with sidebar.

Testing Instructions
Go to Appearance > Editor > Styles and enable "Midnight".
View the post titles in different parts of the design, and confirm that they are readable.

@github-actions
Copy link

github-actions bot commented Oct 8, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan marked this pull request as ready for review October 8, 2024 07:29
@github-actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@beafialho
Copy link
Contributor

beafialho commented Oct 8, 2024

Thank you for working on a fix @carolinan. In my GH Desktop and testing I'm still seeing the letter spacing added somehow, but if it's looking like the screenshot for you, it's good to merge 👍

juanfra
juanfra approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carolina, LGTM ✅

Screen.Recording.2024-10-08.at.10.35.13.mov

@juanfra juanfra merged commit 96685cc into trunk Oct 8, 2024
@juanfra juanfra deleted the update/midnight-letter-spacing branch October 8, 2024 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@juanfra juanfra juanfra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Midnight variation: Fix Title letter spacing in Global Styles

4 participants

@carolinan @beafialho @juanfra