Try: Update the order of the section styles #440
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Looking good and working well to me. I left a small comment (nit) about ordering the sections by number in the different style variations, like they were before.
Screen.Recording.2024-09-27.at.11.51.38.mov
From my perspective, the order matches what @richtabor mentioned here (lightest to darkest), so that's good.
juanfra
added
[Component] Style Variations
[Type] Enhancement
|
Evening: Morning: is also kind of OK It gets worse from there: Noon: Dusk: Afternoon: Twilight: Sunrise: Midnight: |
carolinan
changed the title
Description
I updated the order of the section styles from light to dark.
I placed the files in a new folder called sections.
I did not change the names, they are still called Style 1-5.
Screenshots
Before:
Testing Instructions
Add a group or columns block and confirm that the style sections have the correct color, but a different name and order than before the PR.
Add a few patterns that have a style section, and confirm that the color is the same as before the PR.
Contact location and link -yellow
Link in bio heading, paragraph, links and full-height image -purple
Hero podcast -pink
Logos -off white/ beige